epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011904785


##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##########
@@ -478,6 +484,8 @@ public void testUpdate() throws Exception {
       assertEquals("\u1234", DebugServlet.parameters.get("a")[0]);
 
       // XML response and writer
+      // Have not been able to move this to the Builder pattern, the below 
check for application/xml
+      // always returns as application/javabin when I try this!

Review Comment:
   yeah, I'd love a fresh set of eyes, I don't get why it doesn't work..   
maybe somethign about the `DebugServlet` or some sort of something being 
reused...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to