dsmiley commented on PR #1160: URL: https://github.com/apache/solr/pull/1160#issuecomment-1302673179
Hi Calvnce. I guess you're off to a good start but obviously more to do. You have a new source file here but nothing calls it; I don't think Solr uses any auto-registration based on scanning annotations (as some platforms might do). For example AddReplicaPropertyAPI is registered in CollectionsHandler. You'll want to test this of course, both an automated test but actually try it. I recommend looking at other recent PRs pertaining to the V2 APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
