gerlowskija commented on code in PR #1053:
URL: https://github.com/apache/solr/pull/1053#discussion_r1016750781
##########
solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java:
##########
@@ -1298,19 +1298,25 @@ public Map<String, Object> execute(
V2ApiUtils.squashIntoSolrResponseWithoutHeader(rsp,
addReplicaPropResponse);
return null;
}),
- // XXX should this command support followAliases?
DELETEREPLICAPROP_OP(
DELETEREPLICAPROP,
(req, rsp, h) -> {
- Map<String, Object> map =
- copy(
- req.getParams().required(),
- null,
- COLLECTION_PROP,
- PROPERTY_PROP,
- SHARD_ID_PROP,
- REPLICA_PROP);
- return copy(req.getParams(), map, PROPERTY_PROP);
+ final RequiredSolrParams requiredParams = req.getParams().required();
+ final String propNameToDelete = requiredParams.get(PROPERTY_PROP);
+ final String trimmedPropNameToDelete =
+ propNameToDelete.startsWith(PROPERTY_PREFIX)
+ ? propNameToDelete.substring(PROPERTY_PREFIX.length())
+ : propNameToDelete;
+ final DeleteReplicaPropertyAPI deleteReplicaPropertyAPI =
Review Comment:
Ah, ok. So the "ban" has already been lifted in a sense. I'll give it a
shot here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
