epugh commented on PR #1067: URL: https://github.com/apache/solr/pull/1067#issuecomment-1310227914
@dsmiley you've done a lot with highlighting... I like that this PR exposes all the parameters, it encouraged me to go look at things. I did basic testing and it all appears to work, though often I get no highlighting, which I think is because my combination of parameters doesn't make sense. I think that is okay... in the future if we want to get to a UI that does more handholding on the highlighting params we can do that seperately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org