bszabo97 opened a new pull request, #1182: URL: https://github.com/apache/solr/pull/1182
https://issues.apache.org/jira/browse/SOLR-16504 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR-16504 For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description This is a subtask of SOLR-16367 Switch from CloudLegacySolrClient to CloudSolrClient with description: CloudLegacySolrClient is deprecated; it uses the Apache HTTP client. CloudSolrClient uses the Jetty HTTP client, which supports HTTP 2. In this issue, switch all of Solr to not use CloudLegacySolrClient anymore. This PR is just a work-in-progress solution for migrating the SolrCLI tool from the legacy apache http client to jetty http client. # Solution The solution implements the previous functionalities but with the use of jetty http client instead of the http client. It also processes the response of requests with the use of NamedList as it is done in the jetty client, not using the regular Map as the apache client does. # Tests No additional tests were added. I performed manual tests for all SolrCLI functionalities that I could think except the ones which are done by separate classes like `package`. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
