epugh commented on PR #1158: URL: https://github.com/apache/solr/pull/1158#issuecomment-1326673034
Uh oh, not sure the changes in f49e2a26a46b17c9a9429dde56865c000e1863d1 make sense. Primarily because if the `LBHttp2SolrClient` wraps a `Http2SolrClient`, then we shouldn't be mucking around with the wrapped client, that would violate immutablity? So thinking about backing that change out, and then committing the rest? Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
