stillalex commented on code in PR #1107: URL: https://github.com/apache/solr/pull/1107#discussion_r1038432311
########## solr/core/src/java/org/apache/solr/search/QueryResultKey.java: ########## @@ -33,16 +36,14 @@ public final class QueryResultKey implements Accountable { final Query query; final Sort sort; - final SortField[] sfields; + final List<SortField> sfields; Review Comment: yeah, good question. I don't think it's an easy answer and I could not actually find any test verifying this. not sure about the lucene code (that's where this Accountable interface comes from), I don't have it handy atm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org