gerlowskija opened a new pull request, #1210: URL: https://github.com/apache/solr/pull/1210
https://issues.apache.org/jira/browse/SOLR-16347 # Description Solr supports a system-property ('disable.v2.api') that can be used to turn off the currently experimental v2 API. This sysprop should have been used to control the creation of Jersey applications (i.e. skip them when v2 is disabled), but I missed this logic the first time around. # Solution This commit addresses this lack so that those not using the v2 APIs needn't spend any CPU initializing these Jersey/JAX-RS objects. # Tests Manual testing of the system property flag. Automated tests continue to pass. Ishan's 'solr-bench' benchmark shows the expected performance improvement of not having to create these data structures. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
