[ https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644022#comment-17644022 ]
ASF subversion and git services commented on SOLR-8975: ------------------------------------------------------- Commit cbe238ece56b0332c46e7e508046040851a51097 in solr's branch refs/heads/branch_9x from Eric Pugh [ https://gitbox.apache.org/repos/asf?p=solr.git;h=cbe238ece56 ] SOLR-8975: Use Builder Pattern with all Solr Clients where possible (#1211) Introduce Builder setters for setters that exist on SolrClients for responseParser, requestWriter. Deprecated these SolrClient setters useMultiPartPost, and followRedirects. Update corresponding tests to use these changes. Migrate to try/with resources for Solr Clients where possible in tests. Closes SOLR-10455 and SOLR-10459. > SolrClient setters should be deprecated in favor of SolrClientBuilder methods > ----------------------------------------------------------------------------- > > Key: SOLR-8975 > URL: https://issues.apache.org/jira/browse/SOLR-8975 > Project: Solr > Issue Type: Improvement > Components: SolrJ > Reporter: Jason Gerlowski > Priority: Minor > Attachments: SOLR-8975.patch > > Time Spent: 7h 40m > Remaining Estimate: 0h > > SOLR-8097 added a builder layer on top of each {{SolrClient}} implementation. > Now that builders are in place for SolrClients, the setters used in each > SolrClient can be deprecated, and their functionality moved over to the > Builders. This change brings a few benefits: > - unifies SolrClient configuration under the new Builders. It'll be nice to > have all the knobs, and levers used to tweak SolrClients available in a > single place (the Builders). > - reduces SolrClient thread-safety concerns. Currently, clients are mutable. > Using some SolrClient setters can result in erratic and "trappy" behavior > when the clients are used across multiple threads. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org