dsmiley commented on code in PR #1220:
URL: https://github.com/apache/solr/pull/1220#discussion_r1049951107
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -245,6 +249,16 @@ public Builder withParallelUpdates(boolean
parallelUpdates) {
return this;
}
+ /**
+ * This is the time to wait to refetch the state after getting the same
state version from ZK
+ *
+ * <p>secs
+ */
+ public Builder setRetryExpiryTime(int secs) {
Review Comment:
TimeUnit class was introduced in part to add clarity to call-sites of a
method so the unit is clear. `blah.setTime(TimeUnit.SECOND, 1)` is fine as
well as `blah.setTime(TimeUnit.MINUTE,2)` -- the caller picks the unit
convenient to them. With that design, the method is designed unit-free --
definitely NOT with variables named "second" as you proposed since the unit
could be anything. Internally (implementation of the setter), we need to pick
a unit to standardize to on some internal field to store the result, and name
the field to be clear as to what the internal unit chosen is. (e.g.
retryExpirySecs). Again, that's *internal*, the caller choses a unit
convenient to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
