dsmiley commented on PR #1215: URL: https://github.com/apache/solr/pull/1215#issuecomment-1360572392
I can sympathize somewhat but the change/PR as it is strengthens a weak abstraction, even if it's not pluggable. _Not all abstractions need to be pluggable_. I could remove some comments added in the PR that may be suggestive of the possibility of a subclass that actually isn't present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
