dsmiley commented on code in PR #1215: URL: https://github.com/apache/solr/pull/1215#discussion_r1054005304
########## solr/core/src/java/org/apache/solr/handler/admin/SplitOp.java: ########## @@ -263,8 +263,9 @@ private void handleGetRanges(CoreAdminHandler.CallInfo it, String coreName) thro DocCollection collection = clusterState.getCollection(collectionName); String sliceName = parentCore.getCoreDescriptor().getCloudDescriptor().getShardId(); Slice slice = collection.getSlice(sliceName); - DocRouter router = - collection.getRouter() != null ? collection.getRouter() : DocRouter.DEFAULT; + CompositeIdRouter router = Review Comment: Changed declared type to be specifically CompositeIdRouter because in fact splits depend on CompositeIdRouter in particular. I added a method or two there as well that SplitOp calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org