[ 
https://issues.apache.org/jira/browse/SOLR-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652839#comment-17652839
 ] 

Eric Pugh commented on SOLR-10465:
----------------------------------

Ummm....    where did setIdField go?   I swear I saw it in the source code, but 
now, looking at SOLR-11868, and looking at CloudSolrClient, I don't see it...   
I also don't think I see a withRoutingField or setRoutingField.....    

Is this maybe a JIRA that no longer applies?

> setIdField should be deprecated in favor of SolrClientBuilder methods
> ---------------------------------------------------------------------
>
>                 Key: SOLR-10465
>                 URL: https://issues.apache.org/jira/browse/SOLR-10465
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrJ
>            Reporter: Jason Gerlowski
>            Priority: Minor
>             Fix For: 7.0
>
>         Attachments: SOLR-10465.patch, SOLR-10465.patch
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each 
> {{SolrClient}} can be deprecated, and their functionality moved over to the 
> Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice 
> to have all the knobs, and levers used to tweak {{SolrClient}}s available in 
> a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are 
> mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" 
> behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setIdField}} setter 
> on all {{SolrClient}} implementations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to