janhoy commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061815367
########## solr/modules/opentelemetry/build.gradle: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +apply plugin: 'java-library' + +description = 'Open Telemetry (OTEL) tracer' + +// This is a hacky way to use permitTestUnusedDeclared with bom declared dependencies. +// See https://github.com/gradle-dependency-analyze/gradle-dependency-analyze/issues/108 +configurations { + constraintsOnly + permitUnusedDeclared.extendsFrom constraintsOnly + implementation.extendsFrom constraintsOnly +} + +dependencies { + implementation project(':solr:core') + + constraintsOnly(platform('io.opentelemetry:opentelemetry-bom-alpha')) + + implementation 'io.opentracing:opentracing-api' + implementation 'org.slf4j:slf4j-api' + + implementation 'io.opentelemetry:opentelemetry-sdk' + implementation 'io.opentelemetry:opentelemetry-sdk-trace' + implementation 'io.opentelemetry:opentelemetry-sdk-extension-autoconfigure' + implementation 'io.opentelemetry:opentelemetry-opentracing-shim' + implementation 'io.opentelemetry:opentelemetry-semconv' Review Comment: The three in lines 39-41 needed to be 'implementation', or else I got errors like: ``` /Users/janhoy/git/solr/solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:21: error: package io.opentelemetry.sdk.autoconfigure does not exist import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk; ``` I converted these to `runtimeOnly`: * 'io.opentelemetry:opentelemetry-semconv' * 'io.opentelemetry:opentelemetry-exporter-otlp' * and all the grpc ones -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
