epugh commented on PR #1283: URL: https://github.com/apache/solr/pull/1283#issuecomment-1378837106
This makes sense to me, though I wonder if others might chime in who have stronger opinons? @stillalex I wonder if, for bonus points, you'd like to add this pattern to our forbidden-apis check? Seems like this change is something that we should be continuing to check for in the future? So that it doesn't come back? If you want to add it to forbidden-apis, that would be great, and let's leave it open. Otherwise, if you don't want to do that, then I'll merge once I get another LGTM! Just let me know! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
