risdenk commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1068403694


##########
solr/core/src/java/org/apache/solr/jersey/RequestMetricHandling.java:
##########
@@ -40,9 +39,18 @@
 /**
  * A request and response filter used to initialize and report per-request 
metrics.
  *
- * <p>Currently, JAX-RS v2 APIs rely on a {@link
- * org.apache.solr.handler.RequestHandlerBase.HandlerMetrics} instance from an 
associated request
- * handler.
+ * <p>Currently, Jersey resources that have a corresponding v1 API produce the 
same metrics as their
+ * v1 equivalent and rely on the v1 requestHandler instance to do so. Solr 
facilitates this by
+ * building a map of the JAX-RS resources to requestHandler mapping (a {@link
+ * PluginBag.JaxrsResourceToHandlerMappings}), and using that to look up the 
associated request
+ * handler (if one exists) in pre- and post- filters

Review Comment:
   ```suggestion
    * org.apache.solr.core.PluginBag.JaxrsResourceToHandlerMappings}), and 
using that to look up the
    * associated request handler (if one exists) in pre- and post- filters
   ```
   
   apparently just need to be fully qualified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to