janhoy opened a new pull request, #1295:
URL: https://github.com/apache/solr/pull/1295

   Re-using this global function, we can simplify the js code of the dashboard. 
Note that the backend `/admin/info/system` already returns an array of user's 
permissions, not roles.
   
   During testing I found that the app.js `isPermitted()` function did not 
support the `all` permission, so that's why I added that as well.
   
   This can probably be folded in with #1294, but I wanted to separate it for 
clarity first.
   The `roleMatch()` function that I patched in that PR is still in use one 
other place in `security.js`, in the `onPermFilterOptionChanged()` function. 
Not sure if we can get rid of that too here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to