[
https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679812#comment-17679812
]
Kevin Risden commented on SOLR-15616:
-------------------------------------
This immediately started causing build failures:
FWIW you don't even need the `-Pvalidation.errorprone=true` either.
{code:java}
./gradlew check -x test -Pvalidation.errorprone=true
...
* Where:
Script
'/Users/risdenk/repos/apache/solr/gradle/validation/validate-log-calls.gradle'
line: 230
* What went wrong:
Execution failed for task ':solr:core:validateLogCalls'.
> Found 1 violations in source files (
cause: 'hasPlus: true' Suspicious logging call, Parameterize and possibly
surround with 'if (log.is*Enabled) {..}'. Help at: 'gradlew
helpValidateLogCalls'
/Users/risdenk/repos/apache/solr/solr/core/src/java/org/apache/solr/servlet/CoreContainerProvider.java:433).
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 12s
115 actionable tasks: 56 executed, 59 up-to-date
➜ solr git:(main)
{code}
> Allow thread metrics to be cached
> ---------------------------------
>
> Key: SOLR-15616
> URL: https://issues.apache.org/jira/browse/SOLR-15616
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Ishan Chattopadhyaya
> Assignee: Ishan Chattopadhyaya
> Priority: Major
> Attachments: SOLR-15616-2.patch, SOLR-15616-9x.patch,
> SOLR-15616.patch, SOLR-15616.patch
>
>
> Computing JVM metrics for threads can be expensive, and we should provide
> option to users to avoid doing so on every call to the metrics API
> (group=jvm).
> solr.xml:
> {code}
> <solr>
> <metrics enabled=true>
> <caching>
> <int name="threadsIntervalSeconds">2</int>
> </caching>
> ..
> </metrics>
> </solr>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
