[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1318: SOLR-16636: ZkStateReader.waitForState should not register a watch if state already matches predicate

[sonatype-lift]

sonatype-lift[bot] commented on code in PR #1318:
URL: https://github.com/apache/solr/pull/1318#discussion_r1090210968


##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -832,6 +832,11 @@ public synchronized DocCollection get(boolean allowCached) 
{
       return cachedDocCollection;
     }
 
+    @Override
+    public DocCollection getOrNull() {
+      return cachedDocCollection;

Review Comment:
   <picture><img alt="4% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/4/display.svg";></picture>
   
   *THREAD_SAFETY_VIOLATION:*  Read/Write race. Non-private method 
`ZkStateReader$LazyCollectionRef.getOrNull()` reads without synchronization 
from `this.cachedDocCollection`. Potentially races with write in method 
`ZkStateReader$LazyCollectionRef.get(...)`.
    Reporting because another access to the same memory occurs on a background 
thread, although this access may not.
   
   ---
   
   <details><summary><b>ℹ️ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=375406099&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=375406099&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=375406099&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=375406099&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=375406099&lift_comment_rating=5)
 ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org