andywebb1975 commented on code in PR #1324:
URL: https://github.com/apache/solr/pull/1324#discussion_r1097178117
##########
solr/core/src/java/org/apache/solr/search/ReRankQParserPlugin.java:
##########
@@ -72,25 +74,33 @@ public Query parse() throws SyntaxError {
double reRankWeight = localParams.getDouble(RERANK_WEIGHT,
RERANK_WEIGHT_DEFAULT);
- return new ReRankQuery(reRankQuery, reRankDocs, reRankWeight);
+ String reRankOperator = localParams.get(RERANK_OPERATOR, "add");
+
+ return new ReRankQuery(reRankQuery, reRankDocs, reRankWeight,
reRankOperator);
}
}
private static final class ReRankQueryRescorer extends QueryRescorer {
final double reRankWeight;
+ final String reRankOperator;
Review Comment:
Do you know if there are other examples of enum-based params in Solr? I've
changed the code to validate the value, but couldn't see how to use enums for
this. (I'm not a strong Java programmer!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
