[
https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689710#comment-17689710
]
Eric Pugh commented on SOLR-15959:
----------------------------------
After reviewing you PR, I came back to this issue with the intent to say "How
about naming it node_config.xml", and clearly I am a man of few thoughts, but
sure enough, that was the first comment on this JIRA? So what do we think?
Is it worth doing the rename? I'd be happy to take it up if someone thinks
it's worth doing and puts up a JIRA ;-). Do we handle it like we did with
schema to schema.xml migration, with a deprecation and migration strategy?
> Deprecate loading of solr.xml from ZK
> -------------------------------------
>
> Key: SOLR-15959
> URL: https://issues.apache.org/jira/browse/SOLR-15959
> Project: Solr
> Issue Type: Improvement
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In SOLR-7735, five years ago (committed by me) we allowed loading of solr.xml
> from zookeeper.
> Part of the motivation back then was to be able to put {{solr.xml}} in a
> central place and not being forced to initialize {{SOLR_HOME}} with that
> file, similar to the goal of SOLR-9575. And perhaps also an easy way to
> update solr.xml.
> However, I think it may have been a mistake that should be deprecated and
> ultimately removed. Why? The {{solr.xml}} file is the "node config" for solr.
> Where you set node-level props that need to be there at early node startup.
> So even if you change the file in ZK, nodes will have not way of reloading
> those plugins dynamically without a restart
> The file may even contain local-node-specific settings that shuold differ
> from node to node. Especially during rolling upgrade, it may be important to
> be able to have a different {{solr.xml}} on the new nodes and on the old
> ones. With property substitution you can do some of that, but you cannot add
> XML tags with a sysprop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
