gerlowskija commented on code in PR #1126:
URL: https://github.com/apache/solr/pull/1126#discussion_r1108554248


##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -1095,26 +1095,21 @@ protected void configure() {
                       .to(SolrNodeKeyPair.class)
                       .in(Singleton.class);
                 }
+              })
+          .register(
+              new AbstractBinder() {
+                @Override
+                protected void configure() {
+                  bindFactory(
+                          new InjectionFactories.SingletonFactory<>(
+                              coreAdminHandler.getCoreAdminAsyncTracker()))
+                      .to(CoreAdminHandler.CoreAdminAsyncTracker.class)
+                      .in(Singleton.class);
+                }
               });
       jerseyAppHandler = new 
ApplicationHandler(containerHandlers.getJerseyEndpoints());
     }
 
-    // Do Node setup logic after all handlers have been registered.

Review Comment:
   I added this back in.  Let's discuss if there was a reason it was removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to