noblepaul commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1112485860
##########
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##########
@@ -389,6 +390,7 @@ private String getHostCoreName(
SolrQuery q = new SolrQuery("*:*");
q.add("fl", "id,desc_s,_core_:[core]").add(OMIT_HEADER, TRUE);
p.accept(q);
+ // TODO why is this building a string instead of using the proper
SolrClient???
Review Comment:
>this builds a SolrClient pointing to the qanode.
that is not what it does. `Http2SolrClient.Builder(qaNode).build()` builds a
client with the `qaNode` as the "seed node". Thereafter, it queries the
`qaNode` to get the collection topology and finds out where the request should
be sent. Basically, it behaves the similar to the Zk based provider but using
the REST APIs. The collection topology will never give the COORDINATOR node as
the destination
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
