[
https://issues.apache.org/jira/browse/SOLR-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691375#comment-17691375
]
ASF subversion and git services commented on SOLR-16573:
--------------------------------------------------------
Commit 90f52a858f4890ec41d0d9456e490cc9003196bc in solr's branch
refs/heads/jira/SOLR-16636_revert from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=90f52a858f4 ]
SOLR-16573: Fix tests RE solr.test.sys.prop1
> SolrClientTestRule for EmbeddedSolrServer
> -----------------------------------------
>
> Key: SOLR-16573
> URL: https://issues.apache.org/jira/browse/SOLR-16573
> Project: Solr
> Issue Type: Sub-task
> Reporter: David Smiley
> Priority: Major
> Fix For: 9.2
>
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> See parent issue. Here, create a subclass of ExternalResource (a JUnit
> TestRule, FYI compatible with JUnit 5) that provides access to a SolrClient,
> or that might even be one itself (delegating the request method). Perhaps
> name this "SolrClientTestRule". It will have subclasses for specific types,
> initially just one using EmbeddedSolrServer. It should have a builder to
> configure it. Some test classes can simply configure at its declaration but
> note that others will need to do so afterwards (e.g. in a \@Before or a test
> method). This utility should be in the test-framework and be designed to be
> useful by external projects who write plugins or that want to test with an
> embedded Solr. Therefore it should not contain code that assumes the file
> system of the Solr project itself.
> Out of scope are other implementations, and thus somehow choosing amongst
> them.
> Use this mechanism in EmbeddedSolrServerTestBase, ensuring that "TestHarness"
> (from SolrTestCaseJ4) isn't used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
