justinrsweeney commented on PR #1348: URL: https://github.com/apache/solr/pull/1348#issuecomment-1440676642
> This looks like it does the job. However, I was sort of thinking that compression would be more of a wrapper around the underlying data structure? Kind of like a `ZipInputStream` might wrap a `InputStream`? It seems like there is a lot of logic in the CLI around all the compression, and that it might be ripe for bugs... > > Maybe thinking it would look more like `ZKReader reader = getZKReader()` and you woudn't see all the compression logic? > > Someday I want to break up ZKCli.java and make it easier to reason about. I don't think that'll be doable here. In this case, reading is actually handled fine. Putting files into ZK is where there is a bit of complexity. I did refactor the check if data should be compressed into its own method now to make it a little cleaner. I do agree that a larger refactor of this code would be beneficial in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
