[ https://issues.apache.org/jira/browse/SOLR-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692739#comment-17692739 ]
ASF subversion and git services commented on SOLR-16255: -------------------------------------------------------- Commit a8e72f71650e867463ff249f7ea13145a6723136 in solr's branch refs/heads/branch_9x from Bruno Roustant [ https://gitbox.apache.org/repos/asf?p=solr.git;h=a8e72f71650 ] SOLR-16255: Introduce DirectUpdateHandler2#shouldCommit. > Introduce DirectUpdateHandler2#shouldCommit > ------------------------------------------- > > Key: SOLR-16255 > URL: https://issues.apache.org/jira/browse/SOLR-16255 > Project: Solr > Issue Type: Improvement > Reporter: Bruno Roustant > Priority: Major > Fix For: 9.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently DirectUpdateHandler2 checks IndexWriter.hasUncommittedChanges() > before effectively calling IndexWriter.commit(). > It is also possible for the user to provide custom commit metadata in the > CommitUpdateCommand.commitData field. > The proposed change is to move the check to > IndexWriter.hasUncommittedChanges() in a new protected method > DirectUpdateHandler2.shouldCommit(), which would also check (logical or) if > the CommitUpdateCommand contains user defined commit metadata. It becomes > possible to commit without change, but with user defined commit metadata. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org