magibney commented on code in PR #1378:
URL: https://github.com/apache/solr/pull/1378#discussion_r1119310253
##########
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java:
##########
@@ -571,6 +572,68 @@ public void testGetEmptyResults() throws Exception {
assertEquals(0, out.get(1).size());
}
+ @Test
+ public void testMatchAllPaging() throws Exception {
+ SolrClient client = getSolrClient();
+
+ // Empty the database...
+ client.deleteByQuery("*:*"); // delete everything!
+ if (random().nextBoolean()) {
+ client.commit();
+ }
+ // Add eleven docs
+ List<SolrInputDocument> docs = new ArrayList<>();
+ final int docsTotal = CommonParams.ROWS_DEFAULT + 1;
+ for (int i = 0; i < docsTotal; i++) {
+ SolrInputDocument doc = new SolrInputDocument();
+ doc.addField("id", "id" + i);
+ doc.addField("name", "doc" + i);
+ doc.addField("price", "" + i);
+ docs.add(doc);
+ if (rarely()) {
+ client.add(docs);
+ client.commit();
+ docs.clear();
+ }
+ }
+ client.add(docs);
+ if (random().nextBoolean()) {
+ client.commit();
+ } else {
+ client.optimize();
+ }
+ final List<String> sorts = Arrays.asList("_docid_", "id", "name", "price",
null);
+ Collections.shuffle(sorts, random());
+ final List<Integer> starts =
+ Arrays.asList(0, 1, 2, CommonParams.ROWS_DEFAULT, docsTotal,
CommonParams.ROWS_DEFAULT + 2);
+ Collections.shuffle(starts, random());
+ for (String sort : sorts.subList(0, 1 + random().nextInt(sorts.size() -
1))) {
+ for (int start : starts.subList(0, 1 + random().nextInt(starts.size() -
1))) {
+ final SolrQuery query = new SolrQuery("*:*");
+ if (sort != null) {
+ query.setSort(sort, random().nextBoolean() ? SolrQuery.ORDER.asc :
SolrQuery.ORDER.desc);
+ }
+ if (start > 0 || random().nextBoolean()) {
+ query.setStart(start);
+ }
+ if (usually()) {
+ query.setRows(CommonParams.ROWS_DEFAULT);
+ }
Review Comment:
I see. I get that this block doesn't change the behavior -- so perhaps
misleading that I commented on it. My point was that unless `rows` param is set
artificially small (and it's always effectively `10` here), the results for all
offsets should be within the queryResultCache window, so the first request for
a given `sort` will construct a docList, and all subsequent requests for that
`sort` will I think be entirely served from the queryResultCache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
