risdenk commented on code in PR #1419: URL: https://github.com/apache/solr/pull/1419#discussion_r1123156164
########## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/exporter/SolrExporterIntegrationTest.java: ########## @@ -58,7 +58,7 @@ public void solrExporterDurationMetric() throws Exception { assertTrue(durationHistogram.get("solr_exporter_duration_seconds_sum") > 0); // 17 = (15 buckets in the histogram) + (count metric) + (sum metric) - assertEquals(17, durationHistogram.size()); + assertEquals(18, durationHistogram.size()); Review Comment: I think this is `solr_exporter_duration_seconds_created` but I don't know where it came from right now. These are all the durationHistogram keys ``` [solr_exporter_duration_seconds_bucket{le="+Inf",}, solr_exporter_duration_seconds_bucket{le="0.005",}, solr_exporter_duration_seconds_bucket{le="0.01",}, solr_exporter_duration_seconds_bucket{le="0.025",}, solr_exporter_duration_seconds_bucket{le="0.05",}, solr_exporter_duration_seconds_bucket{le="0.075",}, solr_exporter_duration_seconds_bucket{le="0.1",}, solr_exporter_duration_seconds_bucket{le="0.25",}, solr_exporter_duration_seconds_bucket{le="0.5",}, solr_exporter_duration_seconds_bucket{le="0.75",}, solr_exporter_duration_seconds_bucket{le="1.0",}, solr_exporter_duration_seconds_bucket{le="10.0",}, solr_exporter_duration_seconds_bucket{le="2.5",}, solr_exporter_duration_seconds_bucket{le="5.0",}, solr_exporter_duration_seconds_bucket{le="7.5",}, solr_exporter_duration_seconds_count, solr_exporter_duration_seconds_created, solr_exporter_duration_seconds_sum] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org