[ 
https://issues.apache.org/jira/browse/SOLR-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702769#comment-17702769
 ] 

Michael Gibney commented on SOLR-16707:
---------------------------------------

The only possible benefit of {{async=false}} that I see documented there is
{quote}
Disabling the async option may use slightly less memory per cache entry at the 
expense of increased CPU
{quote}

When this says "slightly", it _really_ means slightly. Specifically, 24 bytes 
-- the cost of one {{CompletableFuture}} -- per entry, according to the 
implementation of {{Accountable.ramBytesUsed()}}; IMO the documented 
distinction is not enough to warrant retaining this as a configuration option. 
Unless maybe there's another, implicit/undocumented reason?

> TestFiltering.testRandomFiltering Caffeine cache async=false 
> IllegalStateException: Recursive update
> ----------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-16707
>                 URL: https://issues.apache.org/jira/browse/SOLR-16707
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mikhail Khludnev
>            Priority: Minor
>
> see the linked mail thread. 
> There are systematic test failures with async=false. 
> Why can't we just turn `async=true` for this test and others?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to