risdenk commented on code in PR #1466: URL: https://github.com/apache/solr/pull/1466#discussion_r1143437955
########## solr/core/src/java/org/apache/solr/api/Api.java: ########## @@ -44,9 +43,7 @@ public Map<String, JsonSchemaValidator> getCommandSchema() { if (commandSchema == null) { ValidatingJsonMap commands = getSpec().getMap("commands", null); commandSchema = - commands != null - ? ImmutableMap.copyOf(ApiBag.getParsedSchema(commands)) - : ImmutableMap.of(); + commands != null ? Map.copyOf(ApiBag.getParsedSchema(commands)) : Map.of(); Review Comment: This also goes for List.of and Set.of - the only case I found so far is that ImmutableSet from Guava cared about the order and that was an issue in one case. All other cases there was no difference that I found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org