[ https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707595#comment-17707595 ]
ASF subversion and git services commented on SOLR-16649: -------------------------------------------------------- Commit a013a29afbf47941df1c0378ff907fda5c5bf7ca in solr's branch refs/heads/branch_9x from Jan Høydahl [ https://gitbox.apache.org/repos/asf?p=solr.git;h=a013a29afbf ] SOLR-16649 Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser (#1526) Backport from main > Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser > ------------------------------------------------------------------------------ > > Key: SOLR-16649 > URL: https://issues.apache.org/jira/browse/SOLR-16649 > Project: Solr > Issue Type: Bug > Components: clients - java > Affects Versions: main (10.0), 9.1.1 > Reporter: Andrzej Bialecki > Assignee: Jan Høydahl > Priority: Major > Fix For: 9.3 > > Attachments: SOLR-16649-1.patch, SOLR-16649.patch > > Time Spent: 40m > Remaining Estimate: 0h > > {{Http2SolrClient:800}} calls {{wantStream(...)}} method but passes the wrong > argument to it - instead of passing the local {{processor}} arg it uses the > instance field {{parser}}. > Throughout this class there's a repeated pattern that easily leads to this > confusion - in many methods a local var {{parser}} is created that > overshadows the instance field, and then this local {{parser}} is passed > around as argument to various operations. However, in this particular method > the argument passed from the caller is named differently ({{processor}}) and > thus does not overshadow the instance field, which leads to this mistake. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org