dsmiley commented on code in PR #1537:
URL: https://github.com/apache/solr/pull/1537#discussion_r1156730296
##########
versions.props:
##########
@@ -1,3 +1,5 @@
+# The lines in this file needs to be lexicographically sorted.
+# Please only add first-party dependencies. Overrides of transitive versions
should be called out in a comment.
Review Comment:
```suggestion
# Please only add direct dependencies. Overrides of transitive versions
should be called out in a comment.
```
##########
gradle/validation/versions-props-sorted.gradle:
##########
@@ -17,17 +17,17 @@
// This ensures 'versions.props' file is sorted lexicographically.
+import java.util.stream.Collectors
+
configure(rootProject) {
task versionsPropsAreSorted() {
doFirst {
def versionsProps = file('versions.props')
- def lines = versionsProps.readLines("UTF-8")
+ def lines = versionsProps.readLines("UTF-8").stream().filter(l ->
!l.matches(/^(#.*|\s*)$/)).collect(Collectors.toList())
Review Comment:
```suggestion
// remove # commented lines and blank lines
def lines = versionsProps.readLines("UTF-8").stream().filter(l ->
!l.matches(/^(#.*|\s*)$/)).collect(Collectors.toList())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
