epugh commented on PR #1182: URL: https://github.com/apache/solr/pull/1182#issuecomment-1497461482
Awesome! I used the BATS tests for the first time…. You may find that it’s worth adding more of them to cover anything requiring manual testing…. On Wed, Apr 5, 2023 at 1:19 PM bszabo97 ***@***.***> wrote: > Thank you @epugh <https://github.com/epugh> for having a look at this! > > I was just about to do some manual testing and rebase this PR to the > current master, unfortunately I had lots of other stuff on my plate > recently and was not able to proceed with this. I hope I can do it tomorrow > and also look into you recent review. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/solr/pull/1182#issuecomment-1497321076>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAFO647GNUIYWSECSIO47TW7VIKXANCNFSM6AAAAAASDTTERU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org