[ 
https://issues.apache.org/jira/browse/SOLR-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710992#comment-17710992
 ] 

David Smiley commented on SOLR-16705:
-------------------------------------

Cool; Pierre's first contribution to Apache Solr!  _Internal forks don't count_ 
;)

Thanks for doing the merge [~ilan].  But we normally update CHANGES.txt which 
specifies (a) version -- don't we want this for 9.3? (b) category -- probably 
an optimization? (c) "what" (can you propose a summary here please, and (d) 
crediting the contributor(s).

> Useless Zookeeper checks in shard leader election
> -------------------------------------------------
>
>                 Key: SOLR-16705
>                 URL: https://issues.apache.org/jira/browse/SOLR-16705
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>    Affects Versions: 9.0, 9.1
>            Reporter: Pierre Salagnac
>            Priority: Minor
>             Fix For: main (10.0)
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> After a Solr node restart, shard leader election code has specific calls to 
> Zookeeper to wait for all replicas to join the election.
> This code is useless when joining leader election for another reason than 
> node restart.
> (in class ShardLeaderElectionContext, call to method 
> areAllReplicasParticipating() is useless and we ignore the returned value).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to