HoustonPutman commented on PR #1556: URL: https://github.com/apache/solr/pull/1556#issuecomment-1505367322
As for the `the licenses/ folder in the -slim release should only contain licenses used by Solr and SolrJ` line, we might want to punt it to another issue that overhauls how we do licenses. Currently we store the licenses for every java gradle module (test and main), however we only want to include licenses for the code we package in a release. So ideally, there would be no licenses included in a source release, and no test licenses would be included in the binary release. This requires more discussion and shouldn't be a blocker for this IMO. (Since we are already handling it incorrectly) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org