[ 
https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726749#comment-17726749
 ] 

ASF subversion and git services commented on SOLR-16507:
--------------------------------------------------------

Commit 859e67c345767dbcad5024df4138029945d00cf9 in solr's branch 
refs/heads/branch_9x from Noble Paul
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=859e67c3457 ]

Revert "SOLR-16507: Refactor out ImplicitSnitch (#1625)"

This reverts commit 8031f7ace15bff54db752e0a7a9333f2fd2bf129.

compilation errors, will fix and commit


> Remove NodeStateProvider & Snitch
> ---------------------------------
>
>                 Key: SOLR-16507
>                 URL: https://issues.apache.org/jira/browse/SOLR-16507
>             Project: Solr
>          Issue Type: Task
>            Reporter: David Smiley
>            Assignee: Noble Paul
>            Priority: Major
>              Labels: newdev
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> The NodeStateProvider is a relic relating to the old autoscaling framework 
> that was removed in Solr 9.  The only remaining usage of it is for 
> SplitShardCmd to check the disk space.  For this, it could use the metrics 
> api.
> I think we'll observe that Snitch and other classes in 
> org.apache.solr.common.cloud.rule can be removed as well, as it's related to 
> NodeStateProvider.
> Only 
> org.apache.solr.cluster.placement.impl.AttributeFetcherImpl#getMetricSnitchTag
>  and org.apache.solr.cluster.placement.impl.NodeMetricImpl refer to some 
> constants in the code to be removed.  Those constants could move out, 
> consolidated somewhere we think is appropriate.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to