trevorpburke commented on PR #571: URL: https://github.com/apache/solr-operator/pull/571#issuecomment-1571023953
> This is a great start! > > So what you have done is make the configuration available in the CRD. So the user can now provide it, however it doesn't actually set the configuration on the underlying Services that are created for the SolrCloud/PrometheusExporter. > > So we still need to: > > * [ ] add the controller logic to set these fields when creating services > * [ ] make sure the fields are copied correctly when updating the services > * [ ] add tests to ensure the fields are propagated correctly > * [ ] Add helm chart options > > If you want an example of a PR that does something very similar, you can look here: #350 > > I'm happy to contribute too, I just don't want to step on your toes! Let me know how I can help 🙂 Thanks for the feedback. I think I addressed updating the `helm/` files that were changed in the PR you linked. Can you share which of those files in #350 are generated vs manually written? AFAICT it looks like I need to also update `controllers/util/solr_util.go`, `controllers/util/prometheus_exporter_util.go`, and `controllers/util/common.go`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
