mlbiscoc commented on PR #1627: URL: https://github.com/apache/solr/pull/1627#issuecomment-1577424719
@dsmiley Thanks for reviewing with suggestions. I made the changes accordingly. Only part I did not change was for adding a higher level test. I also thought about doing this earlier in development but getting duplicate metrics is caused from more than 1 collection. The current configuration for CloudScraperTest is using 1 collection so I would need to refactor all the tests with another collection and anything using that configuration so I felt that a unit test to catch the duplication was suffice and easiest to test for without potentially breaking tests. I know you said it is not critical but if you feel strong on adding a high level test to catch duplication, I can go forward with that doing that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
