bszabo97 commented on PR #1682: URL: https://github.com/apache/solr/pull/1682#issuecomment-1580927426
> If the test would add enough value to justify the effort, we could look at removing the 'final' modifier from ManagedIndexSchema. The only thing that concerns me a little bit is that I was not able to find any other tests testing this part of the code, but still I am not really sure if this test alone would justify removing the final modifier. If you think that it is not needed anyways we can take a look at removing it. Other then that thank you for the review, I will work on the requested changes! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
