tflobbe commented on code in PR #1664:
URL: https://github.com/apache/solr/pull/1664#discussion_r1222196865
##########
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##########
@@ -539,6 +541,21 @@ public Reader readerValue() {
public Number numericValue() {
return null;
}
+
+ @Override
+ public StoredValue storedValue() {
+ if (fieldType().stored() == false) {
+ return null;
+ } else {
+ return new StoredValue(stringValue());
+ }
+ }
+
+ @Override
+ public InvertableType invertableType() {
+ // TODO SOLR-16799 when to use InvertableType.TOKEN_STREAM and when to
use null?
+ return null;
+ }
Review Comment:
It shouldn't matter, right? this is only for stored field retrieval, not for
indexing. This should never be called AFAIK
##########
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##########
@@ -539,6 +541,21 @@ public Reader readerValue() {
public Number numericValue() {
return null;
}
+
+ @Override
+ public StoredValue storedValue() {
+ if (fieldType().stored() == false) {
+ return null;
+ } else {
+ return new StoredValue(stringValue());
+ }
Review Comment:
I guess `fieldType().stored()` will never be `false` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
