dsmiley commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1224296895
########## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ########## @@ -193,12 +193,24 @@ public void checkSchemaField(final SchemaField field) throws SolrException { switch (vectorEncoding) { case FLOAT32: if (dimension > FloatVectorValues.MAX_DIMENSIONS) { - log.warn("The vector dimension "+ dimension +" specified for field "+ field.getName() +" exceeds the current Lucene default max dimension of "+ FloatVectorValues.MAX_DIMENSIONS +". It's un-tested territory, extra caution and benchmarks are recommended for production systems."); + if (log.isWarnEnabled()) { Review Comment: Admittedly I was just complaining about the "if" checks that I am opinionated about -- wasn't you. The PR is fine :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org