gus-asf commented on PR #428: URL: https://github.com/apache/solr/pull/428#issuecomment-1585182176
Next thing I notice is that this is setting up a legacy/user-managed service. We should probably be defaulting to a cloud service? (certanly zookeeper existing beforehand is a pre-requisite, but the user should pass in the zk string, and if the zkroot doesn't exist it should make it. If it does exist the new node should join that cluster? Another thought that's of interest is that we should probably be explicit about environment set in the .service file taking precedence. It would also be nice if we set a system property or other reliable signal visible in the ui that identifies the service file that started solr for when the consultant or new hire has to figure out how someone's istall is(n't?) working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org