[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1670: SOLR-16829: Delegate arg parsing and help usage to java

[via GitHub]

sonatype-lift[bot] commented on code in PR #1670:
URL: https://github.com/apache/solr/pull/1670#discussion_r1225418993


##########
solr/core/src/java/org/apache/solr/cli/CreateCollectionTool.java:
##########
@@ -174,11 +219,56 @@ protected void runCloudTool(CloudSolrClient 
cloudSolrClient, CommandLine cli) th
               collectionName,
               numShards,
               replicationFactor);
-      if (confname != null && !confname.trim().isEmpty()) {
-        endMessage += String.format(Locale.ROOT, " with config-set '%s'", 
confname);
+      if (confName != null && !confName.trim().isEmpty()) {
+        endMessage += String.format(Locale.ROOT, " with config-set '%s'", 
confName);
       }
 
       echo(endMessage);
     }
   }
+
+  /**
+   * Ensure the confDirName is a path to a directory by itself or when it is 
combined with the
+   * solrInstallDir.
+   */
+  private void ensureConfDirExists(String confDirName, String solrInstallDir) {
+    if (!new File(confDirName).isDirectory()) {

Review Comment:
   <picture><img alt="9% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/9/display.svg";></picture>
   
   
<b>*[PATH_TRAVERSAL_IN](https://find-sec-bugs.github.io/bugs.htm#PATH_TRAVERSAL_IN):</b>*
  This API (java/io/File.<init>(Ljava/lang/String;)V) reads a file whose 
location might be specified by user input
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   



##########
solr/core/src/java/org/apache/solr/cli/CreateCollectionTool.java:
##########
@@ -174,11 +219,56 @@ protected void runCloudTool(CloudSolrClient 
cloudSolrClient, CommandLine cli) th
               collectionName,
               numShards,
               replicationFactor);
-      if (confname != null && !confname.trim().isEmpty()) {
-        endMessage += String.format(Locale.ROOT, " with config-set '%s'", 
confname);
+      if (confName != null && !confName.trim().isEmpty()) {
+        endMessage += String.format(Locale.ROOT, " with config-set '%s'", 
confName);
       }
 
       echo(endMessage);
     }
   }
+
+  /**
+   * Ensure the confDirName is a path to a directory by itself or when it is 
combined with the
+   * solrInstallDir.
+   */
+  private void ensureConfDirExists(String confDirName, String solrInstallDir) {
+    if (!new File(confDirName).isDirectory()) {
+      final String fullConfDir = solrInstallDir + "/server/solr/configsets/" + 
confDirName;
+      if (!new File(fullConfDir).isDirectory()) {

Review Comment:
   <picture><img alt="9% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/9/display.svg";></picture>
   
   
<b>*[PATH_TRAVERSAL_IN](https://find-sec-bugs.github.io/bugs.htm#PATH_TRAVERSAL_IN):</b>*
  This API (java/io/File.<init>(Ljava/lang/String;)V) reads a file whose 
location might be specified by user input
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org