HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226879328
########## solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java: ########## @@ -451,6 +451,21 @@ List<ReplicaPosition> assign( SolrCloudManager solrCloudManager, List<AssignRequest> assignRequests) throws AssignmentException, IOException, InterruptedException; + /** + * Balance replicas across nodes. + * + * @param solrCloudManager current instance of {@link SolrCloudManager}. + * @param nodes to compute replica balancing across. + * @param maxBalanceSkew to ensure strictness of replica balancing. + * @return Map from Replica to the Node where that Replica should be moved. + * @throws AssignmentException when balance request cannot produce any valid assignments. + */ + default Map<Replica, String> balanceReplicas( Review Comment: Yeah we can call it `computeBalancing` or something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org