[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1705: SOLR-16841 QueryResponseWriter benchmarks

[via GitHub]

sonatype-lift[bot] commented on code in PR #1705:
URL: https://github.com/apache/solr/pull/1705#discussion_r1227530835


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/NoOpResponseParser.java:
##########
@@ -66,7 +66,7 @@ public NamedList<Object> processResponse(Reader reader) {
   public NamedList<Object> processResponse(InputStream body, String encoding) {
     try {
       StringWriter writer = new StringWriter();
-      new InputStreamReader(body, encoding).transferTo(writer);
+      new InputStreamReader(body, encoding == null ? "UTF-8" : 
encoding).transferTo(writer);

Review Comment:
   <picture><img alt="13% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/13/display.svg";></picture>
   
   <b>*RESOURCE_LEAK:</b>*  resource of type `java.io.InputStreamReader` 
acquired by call to `InputStreamReader(...)` at line 69 is not released after 
line 69.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org