Alex Deparvu created SOLR-16845: ----------------------------------- Summary: BinaryResponseWriter should not attempt cast to Utf8CharSequence Key: SOLR-16845 URL: https://issues.apache.org/jira/browse/SOLR-16845 Project: Solr Issue Type: Improvement Security Level: Public (Default Security Level. Issues are Public) Components: query Reporter: Alex Deparvu
This is a followup of various rollbacks (mainly LUCENE-8805 but also SOLR-14013) in the use of Utf8CharSequence. basically this change https://github.com/apache/solr/commit/5a694ea26ff862ecc874ca798135073d300c2234#diff-95210db504bf3cbe4635d3d09e5e90f990d684dcd324f683e93cb498d171f63dL309 removed the creation of StoredFields based on Utf8CharSequence values, making this BinaryResponseWriter instanceof check useless (https://github.com/apache/solr/blob/66d6a55895fa51074e325d260bbdc14f8beb560a/solr/core/src/java/org/apache/solr/response/BinaryResponseWriter.java#L100). What I see here is an unneeded call to StoredField#getCharSequenceValue for every stored field in the query response, so I am proposing to remove it. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org