stillalex commented on code in PR #1706: URL: https://github.com/apache/solr/pull/1706#discussion_r1233117707
########## solr/core/src/java/org/apache/solr/schema/IntPointField.java: ########## @@ -119,7 +121,16 @@ public Query getSetQuery(QParser parser, SchemaField field, Collection<String> e values[i] = parseIntFromUser(field.getName(), val); i++; } - return IntPoint.newSetQuery(field.getName(), values); + Query pointsQuery = IntPoint.newSetQuery(field.getName(), values); Review Comment: with the caveat that most of this is above my head, I think this code could be written in a simplified manner as ``` if (field.hasDocValues()) { return IntField.newSetQuery(field.getName(), values); } else { return IntPoint.newSetQuery(field.getName(), values); } ``` most of the new code seems to be the same as the IntField.newSetQuery method, so I am thinking calling into it could be a good idea. haven't checked the other types yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org