mkhludnev commented on code in PR #1709:
URL: https://github.com/apache/solr/pull/1709#discussion_r1241152719


##########
solr/solr-ref-guide/modules/configuration-guide/pages/replica-placement-plugins.adoc:
##########
@@ -173,6 +174,18 @@ The plugin will assume that the secondary collection 
replicas are already in pla
 +
 See the section <<withCollection constraint>> below.
 
+`withCollectionShards`::
++
+[%autowidth,frame=none]
+|===
+|Optional |Default: none
+|===
++
+Defines an additional constraint that shards of the primary collections (keys) 
must be located on the same nodes as the shards of the secondary collections 
(values).

Review Comment:
   You are right about nuber 2.
   I think number 1 describes what `withCollections` does. It makes me think 
that `withCollectionShards` might not be good name. WDYT, of: 
   
   1. withShards
   2. shardToShard
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to