[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1730: SOLR-16855: Add a MigrateReplicas API

[via GitHub]

sonatype-lift[bot] commented on code in PR #1730:
URL: https://github.com/apache/solr/pull/1730#discussion_r1247130605


##########
solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java:
##########
@@ -722,4 +723,94 @@ public String toString() {
       }
     };
   }
+
+  /** Context for a placement request still has replicas that need to be 
placed. */
+  class PendingPlacementRequest {
+    boolean hasBeenRequeued;
+
+    final SolrCollection collection;
+
+    final Set<Node> targetNodes;
+
+    final Set<ReplicaPlacement> computedPlacements;
+
+    final Map<String, Map<Replica.ReplicaType, Integer>> 
replicasToPlaceForShards;
+
+    public PendingPlacementRequest(PlacementRequest request) {
+      hasBeenRequeued = false;
+      collection = request.getCollection();
+      targetNodes = request.getTargetNodes();
+      Set<String> shards = request.getShardNames();
+      replicasToPlaceForShards = CollectionUtil.newHashMap(shards.size());
+      shards.forEach(s -> replicasToPlaceForShards.put(s, new HashMap<>()));
+      int totalShardReplicas = 0;
+      for (Replica.ReplicaType type : Replica.ReplicaType.values()) {
+        int count = request.getCountReplicasToCreate(type);
+        if (count > 0) {
+          totalShardReplicas += count;
+          shards.forEach(s -> replicasToPlaceForShards.get(s).put(type, 
count));

Review Comment:
   <picture><img alt="7% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/7/display.svg";></picture>
   
   <b>*NULLPTR_DEREFERENCE:</b>*  null (last assigned on line 751) is 
dereferenced.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org