Willdotwhite commented on PR #1670:
URL: https://github.com/apache/solr/pull/1670#issuecomment-1614280342

   > okay @Willdotwhite I had to restore a change to `StatusTool.java` to make 
it work on Unix.. Is it possible that we have the .cmd and the .sh somewhat 
working at cross purposes in how we decide to output the help?
   
   Sorry @epugh , I think I was just a bit too tired yesterday and flubbed my 
testing - I've just put the condition back to `if ((cli.getOptions().length == 
0 && cli.getArgs().length == 0) || cli.hasOption("h") || cli.hasOption("help")) 
{` on my machine and the status checks work as before; not really sure what 
happened there 🤔 
   
   I think both are inline (although I'll fully rebuild from this branch during 
my coffee break in ~2 hours and confirm).
   
   By the way, a bit of copypasta has slipped through the net on the hashbang 
of `solr.sh` [just 
here](https://github.com/apache/solr/pull/1670/files#diff-49c29c8f653341f48008c38f5f2cf970fa430cdca29181c819d7bdcfcc722980R1)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to